Open
Conversation
Pl217
added
the
needs minor changes
unocha-hpc
approved these changes
May 21, 2025
unocha-hpc
left a comment
unocha-hpc
left a comment
There was a problem hiding this comment.
Checks have passed and this pull request is ready for manual review
Now is not exact match but 'isLike'
Reorder methods to reduce the select set Change 'const' for 'let' to just copy the results rather than iterating over it
This allow to do intersection more performant
This allow to handle all request at the same time Which helps with the time-performance of the endpoint
Using this method on branded IDs does harm, because we lose ID branding and get generic `number` type instead
Some of ID definitions were `number` because they predated the existence of hpc-api-core
The types of these variables are `OrganizationId | null` and if type is correct, there is no need for nullish coalescing
This iterator is implicit when using `for...of` loop
The same thing is happening in `getOrCreate()` below
manelcecs
force-pushed
the
HPC-10227
branch
2 times, most recently
from
8b6621a to
991c57f
Compare
unocha-hpc
approved these changes
Jun 30, 2025
unocha-hpc
left a comment
unocha-hpc
left a comment
There was a problem hiding this comment.
Checks have passed and this pull request is ready for manual review
unocha-hpc
approved these changes
Jun 30, 2025
unocha-hpc
left a comment
unocha-hpc
left a comment
There was a problem hiding this comment.
Checks have passed and this pull request is ready for manual review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This started as I have noticed that branded IDs aren't done properly in bunch of places in the codebase, but I also did some other improvements along the way. @manelcecs, there are two TODO comments in which I wanted to point out typing issues I'd like you to improve.