Skip to content

fix: Fixed a hidden logging bug in add_tokenize_docs in word_count.py #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ginic merged 1 commit into from
Jun 5, 2025
Merged

fix: Fixed a hidden logging bug in add_tokenize_docs in word_count.py #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ You should also add project tags for each release in Github, see [Managing relea
## [Unreleased]
### Changed
- GitHub workflow for linting and formatting uses ruff as a separate job

- Fixed Logging bug in `add_tokenize_docs` in `word_count.py`
### Removed
- GitHub action to run flake8 for linting in build
- Removed wildcard from corpus-counter script dependency
Expand Down
2 changes: 1 addition & 1 deletion src/cdstemplate/word_count.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def add_tokenized_doc(self, token_list):
logger.info("Adding %s token(s) case insensitively", len(token_list))
self.token_counter.update([w.lower() for w in non_empty_tokens])
else:
logger.info("Adding %s token(s) case insensitively", len(token_list))
logger.info("Adding %s token(s) case sensitively", len(token_list))
self.token_counter.update(non_empty_tokens)
after_vocab_size = self.get_vocab_size()

Expand Down