Merged
Conversation
munwalk
approved these changes
Apr 5, 2026
Collaborator
munwalk
left a comment
There was a problem hiding this comment.
3주차 과제 수고하셨습니다!
API 설계를 보니 /api/v1/...로 버전 관리를 하신 점이 좋습니다! 홈 화면을 상단과 하단으로 분리해서 각각의 목적에 맞게 API를 구성하신 점도 훌륭하네요. GET /api/v1/missions/challenging, GET /api/v1/missions/completed로 진행중/완료 미션을 명확히 나눈 것도 직관적입니다.
페이징 처리도 page, size로 구현하셨고, Authorization 헤더를 일관되게 사용하신 점이 좋습니다. PATCH /api/v1/missions/{memberMissionId}/success에서 Path Variable을 잘 활용하셨네요!
다만, 리뷰 작성 API에서 Path Variable 설명에는 memberMissionId가 있는데, 실제 Endpoint /api/v1/reviews에는 Path Variable이 없습니다. memberMissionId를 Path Variable로 사용하려면 /api/v1/member-missions/{memberMissionId}/reviews 형태로 수정하고, Request Body에서는 제거하는 게 RESTful합니다! 그리고 Response Body 예시가 있으면 프론트엔드 입장에서 더 명확하게 이해할 수 있을 것 같아요!
수고하셨습니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.