Merged
Conversation
munwalk
approved these changes
Mar 31, 2026
Collaborator
There was a problem hiding this comment.
2주차 과제 수고하셨습니다!
쿼리 작성을 보니 진행중/완료 미션을 별도 쿼리로 분리하신 점이 인상적입니다! 특히 완료 미션 쿼리에서 LEFT JOIN review로 리뷰 작성 여부를 확인하고, review.id가 null일 때만 리뷰 남기기 버튼을 활성화시키는 로직이 좋습니다. 홈 화면도 상단과 하단으로 나눠서 각각의 목적에 맞게 쿼리를 구성하신 점이 훌륭하네요!
리뷰 조회 쿼리에서 review → member_mission → mission → store 경로로 조인하신 것도 1주차 ERD 설계(review가 member_mission 기준)를 정확히 반영하셨습니다. DATEDIFF(mission.end_at, NOW())로 D-day 계산하신 것도 좋고, CASE WHEN으로 완료 미션만 집계하신 부분도 깔끔합니다!
다만, 2주차 미션에서 페이징 포함이 필수인데 현재 쿼리에는 LIMIT 10만 있고 Cursor based나 Offset based 페이징 구현이 보이지 않습니다. 진행중/완료 미션 쿼리와 홈 화면 쿼리에 OFFSET (n-1)*10 또는 커서 조건을 추가해주세요!
수고하셨습니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.