-
Notifications
You must be signed in to change notification settings - Fork 0
Feat(auth): 심사용 로그인 플로우 및 JWT 발급 로직 추가 #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
annalee8595
wants to merge
5
commits into
dev
Choose a base branch
from
feat/review-auth
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7fddfc5
feat: update dependencies and refactor cookie parsing in main.ts
annalee8595 0f4c52b
feat: add cookie-parser dependency
annalee8595 7eea265
feat: 카카오 로그인시 사용자 정보(sex/birthdate/age) 자동 반영
annalee8595 2e8b72b
refactor: onboarding 계산 로직에서 removed the birthdate check
annalee8595 0b69a10
feat: implement review login
annalee8595 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| import { Body, Controller, Post, Res } from '@nestjs/common'; | ||
| import { ApiBody, ApiOkResponse, ApiOperation, ApiTags } from '@nestjs/swagger'; | ||
| import type { Response } from 'express'; | ||
| import { ConfigService } from '@nestjs/config'; | ||
| import { ReviewAuthService } from '../services/review-auth.service'; | ||
| import { ReviewLoginRequestDto } from '../dtos/review-login-request.dto'; | ||
| import { ReviewLoginResponseDto } from '../dtos/review-login-response.dto'; | ||
| import { buildRefreshTokenCookieOptions } from '../utils/refresh-token-cookie'; | ||
|
|
||
| @ApiTags('Auth') | ||
| @Controller('auth/review') | ||
| export class ReviewAuthController { | ||
| constructor( | ||
| private readonly reviewAuthService: ReviewAuthService, | ||
| private readonly configService: ConfigService, | ||
| ) {} | ||
|
|
||
| @Post('login') | ||
| @ApiOperation({ summary: 'Review login' }) | ||
| @ApiBody({ type: ReviewLoginRequestDto }) | ||
| @ApiOkResponse({ | ||
| type: ReviewLoginResponseDto, | ||
| headers: { | ||
| 'Set-Cookie': { | ||
| description: 'Sets refresh_token cookie', | ||
| }, | ||
| }, | ||
| }) | ||
| async login( | ||
| @Body() body: ReviewLoginRequestDto, | ||
| @Res({ passthrough: true }) res: Response, | ||
| ): Promise<ReviewLoginResponseDto> { | ||
| const { refreshToken, ...result } = | ||
| await this.reviewAuthService.loginWithReview(body); | ||
|
|
||
| res.cookie( | ||
| 'refresh_token', | ||
| refreshToken, | ||
| buildRefreshTokenCookieOptions(this.configService), | ||
| ); | ||
|
|
||
| return result; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import { ApiProperty } from '@nestjs/swagger'; | ||
| import { IsEmail, IsNotEmpty, IsString } from 'class-validator'; | ||
|
|
||
| export class ReviewLoginRequestDto { | ||
| @ApiProperty({ example: 'admin@example.com' }) | ||
| @IsEmail() | ||
| @IsNotEmpty() | ||
| email!: string; | ||
|
|
||
| @ApiProperty({ example: 'supersecretreviewloginkey' }) | ||
| @IsString() | ||
| @IsNotEmpty() | ||
| secret!: string; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import { ApiProperty } from '@nestjs/swagger'; | ||
|
|
||
| export class ReviewLoginUserDto { | ||
| @ApiProperty({ example: 1 }) | ||
| userId: number; | ||
|
|
||
| @ApiProperty({ example: 'nickname', nullable: true }) | ||
| nickname: string | null; | ||
| } | ||
|
|
||
| export class ReviewLoginResponseDto { | ||
| @ApiProperty({ example: 'jwt_access_token' }) | ||
| accessToken: string; | ||
|
|
||
| @ApiProperty({ example: true }) | ||
| isNewUser: boolean; | ||
|
|
||
| @ApiProperty({ example: true }) | ||
| onboardingRequired: boolean; | ||
|
|
||
| @ApiProperty({ type: ReviewLoginUserDto }) | ||
| user: ReviewLoginUserDto; | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cookieis added as a direct dependency, but there are no direct imports/usages of thecookiepackage in the source (onlycookie-parser). Unless something outside this PR relies on importingcookiedirectly, consider removing it to avoid carrying an unused dependency and duplicatecookieversions in the lockfile.