Skip to content

main 반영 및 deploy#167

Merged
Lidohyeon merged 22 commits intomainfrom
dev
Feb 19, 2026
Merged

main 반영 및 deploy#167
Lidohyeon merged 22 commits intomainfrom
dev

Conversation

@Lidohyeon
Copy link
Copy Markdown
Contributor

이슈 번호

close # 00

주요 변경사항

테스트 결과 (스크린샷)

참고 및 개선사항

annalee8595 and others added 22 commits February 11, 2026 02:51
feat: 차단 시 채팅 기능 제한(생성/전송/읽음/삭제/발급) 및 WS 에러 코드 통일
…interceptor-확인

Refactor 알림 파라미터 수정 및 block interceptor 확인
refactor: WebSocket 공용 모듈 분리 및 ChatGateway 역할 축소
@Lidohyeon Lidohyeon merged commit 0193308 into main Feb 19, 2026
4 checks passed
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8a92b3a146

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +46 to +48
if (typeof v === 'number') {
if (!Number.isFinite(v) || v <= 0) return null;
return BigInt(Math.floor(v));
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Reject fractional JWT subject values

toPositiveBigInt floors numeric sub claims (1.9 becomes 1) instead of rejecting them, and WsAuthService.attachUser uses that parsed value as the authenticated user ID. A signed token with a non-integer numeric sub would therefore authenticate as a different account, which is an identity-mapping bug in auth handling; this parser should require an integer value before converting.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants