Open
Conversation
Add any non-default port from request.
der
reviewed
Dec 19, 2022
Contributor
der
left a comment
der
left a comment
There was a problem hiding this comment.
Sorry, don't think this works.
When running raw then indeed the port in the request is correct and you can redirect this way.
However, in the "normal" case when running behind a proxy server the port seen by the registry in the request and the port exposed to the user are generally different. So I think (but haven't tested) that this change would break normal deployments. Am I missing something?
Contributor
Author
|
Yes, I went through the same reckoning. We'd need to understand whether the
proxy rewrites the location header.
An alternative is to use a relative URI in the location header.
…On Mon, 19 Dec 2022, 09:33 Dave Reynolds, ***@***.***> wrote:
***@***.**** commented on this pull request.
Sorry, don't think this works.
When running raw then indeed the port in the request is correct and you
can redirect this way.
However, in the "normal" case when running behind a proxy server the port
seen by the registry in the request and the port exposed to the user are
generally different. So I *think* (but haven't tested) that this change
would break normal deployments. Am I missing something?
—
Reply to this email directly, view it on GitHub
<#175 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB7Y4ZAK3G2TRTYGL3JUHLWOATVTANCNFSM6AAAAAAS4BGWCQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test for redirect location.
Add any non-default port from request.
Fixes #174.