Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey will! I went through test-compile_acs_data and added in stop() messages around any errors - and attempted to correct them in the compile_acs_data.R script. I'm realizing now that the -dplyr::matches("percent") might not be necessary since the columns were coming from the dataframe that had been created by the function to begin with (sorry about that, didn't register until the end)!
Other than that, I had one thought/question:
For educational_attainment_highschool_diploma_percent - is that the number of people whose furthest degree of education was a high school diploma - so this won’t include people who have some college or a masters AND have a high school diploma? If so - could that also go in the documentation or add as a note in the compile_acs script just to clarify?