Skip to content

Update employment 1-year data for 2024#562

Open
jwalsh28 wants to merge 2 commits intotranche2from
iss496b
Open

Update employment 1-year data for 2024#562
jwalsh28 wants to merge 2 commits intotranche2from
iss496b

Conversation

@jwalsh28
Copy link
Collaborator

This PR updates the employment metric with 2024 data

Main changes are:

  1. Update the dates in the QMD files to read in 2024
  2. Fix an issue with the IPUMS pull function because of a changed variable name
  3. Create a subfolder to organize single year HTLM output files

Copy link
Contributor

@malcalakovalski malcalakovalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I do think 90% of the code seems similar across .qmd files and I wonder if this metric could benefit from a single parametrized quarto doc. Alternatively, the common logic across the docs could be extracted into functions in 09_employment/R/ (data cleaning, validation, etc.).

Also, out of curiosity, what model did you use for the AI documentation?

I also think using urbnthemes for consistency with the rest of the plots in this project would be good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants