Conversation
malcalakovalski
approved these changes
Feb 13, 2026
Contributor
There was a problem hiding this comment.
This looks good to me! I do think 90% of the code seems similar across .qmd files and I wonder if this metric could benefit from a single parametrized quarto doc. Alternatively, the common logic across the docs could be extracted into functions in 09_employment/R/ (data cleaning, validation, etc.).
Also, out of curiosity, what model did you use for the AI documentation?
I also think using urbnthemes for consistency with the rest of the plots in this project would be good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the employment metric with 2024 data
Main changes are: