Bug fixes and continuous integration updates #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martjanz
approved these changes
Dec 21, 2017
smmaurer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: This PR now includes a number of small changes and bug fixes.
Fixes a bug in computing max-profit over all forms. If the argument to "forms" is None, max-profit should be computed over all forms present in the feasibility table. This was raised by @hanase in issue Bug in computing max profit over all forms #59, and originally in Compute max-profit over all forms if "form" is None urbansim#194.
Migrates the Travis hooks from urbansim/developer to udst/developer, to restore continuous integration of the repository.
Removes urbansim_parcels dependencies from the Travis script, because these aren't working following the move to UDST. See issue Fix deploy keys for Travis CI #63.
Fixes a problem in sqftproforma.py where arrays possibly containing nans were being compared to numeric values. This evaluated correctly, but caused numpy to raise a warning.