feat: sync meter/tala system with TypeScript + migrate to uv #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses issues #58 and #59: **Issue #58 - Remove display_tempo:** - Remove display_tempo property and setter from Meter class (was reverted in web app) - Remove associated tests **Issue #59 - Sync meter/tala features:** - Add TalaName enum with 14 predefined Hindustani talas - Add tala_presets class variable with hierarchy and vibhaga definitions - Add Meter.from_tala() classmethod for creating meters from presets - Add tala_name and vibhaga instance variables to Meter - Add segment boundary methods: - get_segment_boundary_indices() - get vibhag boundary indices - get_matra_pulses() - get matra-level pulses (every Nth pulse based on hierarchy) - is_segment_boundary() - check if pulse is at vibhag boundary - get_segment_for_matra_index() - get segment range for matra index - offset_segment_boundary() - offset boundary with proportional redistribution - _offset_pulse_direct() - internal pulse offset helper - Add lowest_layer property to Pulse class - Update to_json/from_json for tala_name and vibhaga serialization - Add comprehensive tests for all new functionality (18 new tests) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Migrate from pipenv to uv for faster, more reliable dependency management. uv.lock replaces Pipfile.lock for dependency locking. To use uv: - Install: curl -LsSf https://astral.sh/uv/install.sh | sh - Sync deps: uv sync --all-extras - Run tests: uv run pytest 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
|
📦 Test Package Built Successfully! This PR has been automatically built and uploaded to TestPyPI for testing. 🔗 TestPyPI Link: https://test.pypi.org/project/idtap/ To test this version: pip install --index-url https://test.pypi.org/simple/ idtap✅ All tests passed and package builds successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Meter/Tala System (#58, #59)
display_tempoproperty (reverted in web app)TalaNameenum with 14 predefined Hindustani talastala_presetsclass variable with hierarchy and vibhaga definitionsMeter.from_tala()classmethod for creating meters from presetsget_segment_boundary_indices()- get vibhag boundary indicesget_matra_pulses()- get matra-level pulsesis_segment_boundary()- check if pulse is at vibhag boundaryget_segment_for_matra_index()- get segment range for matra indexoffset_segment_boundary()- offset boundary with proportional redistributionlowest_layerproperty toPulseclasstala_nameandvibhagaUV Migration
uv.lockfor dependency lockingTest plan
🤖 Generated with Claude Code