Fix: preserve time_resolution in crop methods #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both crop methods were not passing time_resolution to new SpectrogramData instances, causing them to fall back to DEFAULT_TIME_RESOLUTION (0.01508s) instead of the accurate value calculated from database duration (e.g. 0.015103s). This small discrepancy accumulates over long recordings, causing significant timing misalignment. For a 2192-second recording, the error reached ~0.15s. Now both methods preserve the parent spectrogram's time_resolution, ensuring accurate timing throughout the crop chain. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
📦 Test Package Built Successfully! This PR has been automatically built and uploaded to TestPyPI for testing. 🔗 TestPyPI Link: https://test.pypi.org/project/idtap/ To test this version: pip install --index-url https://test.pypi.org/simple/ idtap✅ All tests passed and package builds successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
crop_frequency()andcrop_time()to preservetime_resolutionparameterDEFAULT_TIME_RESOLUTIONinstead of using the accurate valueProblem
When spectrograms are cropped, the new SpectrogramData instances were created without passing
time_resolution, causing them to use the default value (0.01508s) instead of the accurate value calculated from the recording database (e.g., 0.015103s).This small 0.00023s discrepancy accumulates over long recordings:
Changes
crop_frequency(): Now passestime_resolution=self._time_resolutionto new instancecrop_time(): Now passestime_resolution=self._time_resolutionto new instanceTesting
🤖 Generated with Claude Code