Fix spectrogram frequency axis orientation #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The server data has row 0 = highest frequency, but freq_bins property calculates assuming row 0 = lowest frequency. This caused frequency cropping to select the wrong portion of the spectrum (e.g., requesting 200-400 Hz would actually return high frequencies like 2000-2400 Hz). Now flip the data immediately after loading in from_audio_id() so: - Row 0 = lowest frequency (matching freq_bins[0]) - Row -1 = highest frequency (matching freq_bins[-1]) This fixes frequency alignment between spectrograms and pitch contours in visualization contexts. Note: Visualizations using this API should remove any flipud() calls they were using to work around this issue. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
📦 Test Package Built Successfully! This PR has been automatically built and uploaded to TestPyPI for testing. 🔗 TestPyPI Link: https://test.pypi.org/project/idtap/ To test this version: pip install --index-url https://test.pypi.org/simple/ idtap✅ All tests passed and package builds successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
np.flipud()inSpectrogramData.from_audio_id()after loading data from serverfreq_binsproperty orderingImpact
flipud()calls they were using as workaroundsTest Plan
🤖 Generated with Claude Code