Fix Issue #12: Complete raga structure handling improvements + PyPI workflow enhancements #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### 🚀 New Features
- Enhanced raga format validation with helpful error messages
- Automatic conversion of multiple raga input formats:
- Strings: "Rageshree" → AudioRaga(name="Rageshree")
- Name dicts: {"name": "Rageshree"} → AudioRaga(name="Rageshree")
- Legacy format: {"Rageshree": {"performance_sections": {}}} → AudioRaga(name="Rageshree")
- Musical Raga objects → AudioRaga with extracted name
- Early validation in upload_audio() method with clear error context
### 🐛 Bug Fixes
- Fixed 'dict' object has no attribute 'to_json' error when using plain dictionaries
- Prevents silent failures from incorrect raga parameter usage
- Added detection of wrong Raga class (musical analysis vs audio metadata)
### 📚 Documentation
- Updated AudioMetadata and upload_audio() docstrings with raga format examples
- Added comprehensive documentation for all supported raga input formats
### 🧪 Testing
- Added 13 comprehensive test cases covering all raga validation scenarios
- Tests validate error messages, auto-conversion, and edge cases
- All 304 existing tests continue to pass
### 🔧 Developer Experience
- Backward compatible - existing AudioRaga usage unchanged
- Auto-conversion makes the API more intuitive and flexible
- Clear error messages guide users to correct usage patterns
### ⚠️ Breaking Changes
None - fully backwards compatible with existing valid usage
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
Minor improvement to get_auth_info() method for better user information display. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Add proper authentication instructions for TestPyPI vs production PyPI: - Separate API tokens required for each service - Environment variable configuration in .envrc - Correct upload commands with proper token usage - Explains why original TestPyPI upload failed This addresses the authentication issues encountered during testing workflow. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
### 📚 Documentation Updates - Enhanced TestPyPI authentication setup in CLAUDE.md - Added comprehensive PyPI publishing workflow documentation - Clarified authentication requirements for TestPyPI vs production PyPI ### 🔧 Infrastructure Improvements - Fixed TestPyPI upload authentication with proper token configuration - Validated complete testing workflow with both TestPyPI and production PyPI - Confirmed Issue #12 raga handling improvements are working correctly ### ✅ Verification - All 304 tests continue to pass - TestPyPI upload successful: https://test.pypi.org/project/idtap/0.1.12/ - Production PyPI upload successful: https://pypi.org/project/idtap/0.1.12/ ### 🔄 Backward Compatibility Fully backward compatible - all existing usage patterns continue to work unchanged. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the fix for Issue #12 and adds significant PyPI workflow improvements:
🚀 Issue #12 Resolution (Already Released in v0.1.11)
📚 Documentation & Infrastructure Improvements (v0.1.12)
✅ Verification Status
🔄 User Impact
Before (Issue #12):
After (Now Working):
🧪 Testing Workflow Improvements
The PR establishes a robust testing workflow:
Test Plan
Breaking Changes
None - fully backwards compatible with existing usage patterns.
🤖 Generated with Claude Code