adds an alternative to delete lines using sed#14
Open
dpshelio wants to merge 2 commits intoUCL-ARC:masterfrom
Open
adds an alternative to delete lines using sed#14dpshelio wants to merge 2 commits intoUCL-ARC:masterfrom
dpshelio wants to merge 2 commits intoUCL-ARC:masterfrom
Conversation
heatherkellyucl
requested changes
Jun 8, 2020
Collaborator
heatherkellyucl
left a comment
There was a problem hiding this comment.
I think you'd need to add a lot more explanation if offering a sed command - what is the d, what does the -i.bak do... People are quite likely to add spaces. This is for an audience not familiar at all with sed.
Member
Author
|
Updated - I hope this makes it clearer. If they add a space, the error message may give them a hint... right? 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think using
sedwould be less error-prone than usingpico.