-
Notifications
You must be signed in to change notification settings - Fork 0
Optimise movement of CshiftTable to GPU #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
qiUip
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really great and very concise! I'm impressed by how much you managed to minimise the changes.
Only "comments" are questions to help me understand things correctly, and to clean up the branch before we merge, which I will do once you give me the go ahead as they are messes I introduced for the profiling branch.
|
To check MPI performance: |
|
@asifsamiarain , benchmarks to run (make sure you checkout the latest version of this branch): MPI configurations:
Benchmarks to run: Let me know if any of this doesn't make sense! |
|
The pgda032 is upstream develop (hash: 3d01486 & dated: 20250306) and pgda034 is also upstream develop but having relevant changes adopted for Grid/cshift/Cshift_common.h, Grid/cshift/Cshift_mpi.h, Grid/cshift/Cshift_table.cc (till hash: 40ee258 & dated: 20250321). While both experiment ids also possess the changes mentioned via the PRs (paboyle#465 and paboyle#471 please be aware). A bit about terminology (just in case): |
|
Closing this PR in favour of paboyle#476 , which is clean and opened against the upstream. |
FIxes #21
Still needs a bit of work:
Cshift_mpi.h--grid 16.16.16.32 --mpi 1.1.1.2ok?`