Skip to content

Conversation

@ihsan314
Copy link
Collaborator

Description

Upgraded repo to ROS Noetic and switched to installing the realsense library via apt.

Testing Done

Verified in a docker container that all dependencies were installed and that catkin_make succeeded.

Resolved Issues

Resolves #384

Review Checklist

(Please check every item to indicate your code complies with it (by changing [ ]->[x]). This will hopefully save both you and the reviewer(s) a lot of time!)
It is the reviewers responsibility to also make sure every item here has been covered

  • Start of document comments: each .cpp and .h file should have a comment at the start of it. See files in src/sample_package for examples.
  • Function comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the classes defined in src/sample_package
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue
    Feel free to make additions of things that we should be checking to this file if you think there's something missing!!!!

@ihsan314 ihsan314 requested a review from Roozki July 30, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to ROS 2 and Ubuntu 20.04

1 participant