Fix: double counting of storage used in Items Report dashboard (Issue #15) #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
zoidy
deleted the
15-bug-double-counting-of-certain-items-in-items-dashboard
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue stemmed from data not being cleared in the Google Sheet prior to adding new data. This was intentional in order to capture the date a record was last updated/added to the sheet. This necessitated deduping the added records to filter out ones that hadn't changed. However, the deduping method did not account for when an item goes from unpublished to published. The historical record of update dates is not being used so to simplify the code and fix the bug, the sheet is now cleared before adding any new data. The deduping code has been removed as it is no longer needed.
Fixes #15
Screenshots or additional context
Testing (if applicable)
Ran the function manually on DO and the report generates the correct data.