Allow reactions with neutrons and other particles#38
Open
gvdeynde wants to merge 2 commits intoTypsium:mainfrom
Open
Allow reactions with neutrons and other particles#38gvdeynde wants to merge 2 commits intoTypsium:mainfrom
gvdeynde wants to merge 2 commits intoTypsium:mainfrom
Conversation
Collaborator
|
this looks like it could break some things. because it generalises our search pattern by a lot. There's stuff like delta H etc where people are using greek letters but don't mean elements. I'll test some things before merging. Alternatively I would suggest that we keep it as is and provide a second alternative match that detects anything inside of brackets or something like that. But I think it could work like you suggested |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37