Conversation
When Whisper hallucinates a different language, the translation step would incorrectly translate already-correct text. Now also checks the user's configured source language against the target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When Whisper hallucinates a different language (e.g. detecting English while the user speaks Italian), the translation step would incorrectly translate already-correct text. This adds a check so that when the user's explicitly configured source language matches the translation target, translation is skipped regardless of Whisper's detected language. Auto-detect behavior is preserved since the configured language is null in that case.
Test Plan
ProcessAsync_Translation_SkippedWhenEffectiveLanguageMatchesTargetverifies the hallucination scenario