Conversation
Extend the hotkey system to support mouse buttons (3+) as shortcuts for all dictation modes. Adds otherMouseDown/Up to CGEventTap and NSEvent monitors, mouse button recording in HotkeyRecorderView, display names, and double-tap support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for mouse buttons (3+) as hotkey shortcuts for all dictation modes (hybrid, push-to-talk, toggle, prompt palette) and profile hotkeys. Users can now assign side mouse buttons (e.g. Button 4/5) via the hotkey recorder, with full double-tap support and event suppression via CGEventTap so assigned buttons don't trigger their default action (e.g. browser back). Left/right click are intentionally excluded.
Changes:
UnifiedHotkey: newmouseButton: UInt16?property with.mouseButtonKind, backward-compatible CodableHotkeyService: expanded CGEventTap + NSEvent monitors forotherMouseDown/otherMouseUp, self-contained mouse button processing inprocessKeyEventwith double-tap state machine, display names, conflict detectionHotkeyRecorderView: mouse button recording with double-tap detection, updated prompt textTest Plan