Open
Conversation
DeepakSF25
reviewed
Sep 4, 2022
assi2/css/style.css
Outdated
| display: flex; | ||
| flex-direction: column; | ||
| height: 300px; | ||
| /* background-color: aquamarine; */ |
Collaborator
There was a problem hiding this comment.
remove this commented line
DeepakSF25
reviewed
Sep 4, 2022
| display: flex; | ||
| justify-content: center; | ||
| /* align-items: center; */ | ||
| } |
Collaborator
There was a problem hiding this comment.
add an enter - There should be proper formatting, no cluttered code would be accepted
DeepakSF25
reviewed
Sep 4, 2022
assi2/scripts/main.js
Outdated
| @@ -0,0 +1,124 @@ | |||
| let data = [ | |||
| { | |||
| firstName: "Sunny", | |||
Collaborator
There was a problem hiding this comment.
put this data in json file and import from there
DeepakSF25
reviewed
Sep 4, 2022
assi2/scripts/main.js
Outdated
| for (let employeeData of data) { | ||
| let row = table.insertRow(rowCount); | ||
| let cellNum = 0; | ||
| for (let j in employeeData) { |
Collaborator
There was a problem hiding this comment.
variable name should be descriptive, you cant use j
DeepakSF25
reviewed
Sep 4, 2022
assi2/scripts/main.js
Outdated
| Array.from(staticCellData).forEach((input) => { | ||
| input.style.display = "inline"; | ||
| }); | ||
| document.getElementById(`normal-action-${n}`).style.display = "inline"; |
Collaborator
There was a problem hiding this comment.
this code is redundant, write this code in a function
DeepakSF25
reviewed
Sep 4, 2022
assi2/scripts/main.js
Outdated
| function editRow(n) { | ||
| let editableRowInput = document.getElementsByClassName(`edit-info-row-${n}`); | ||
| let staticCellData = document.getElementsByClassName(`info-row-${n}`); | ||
| console.log(typeof editableRowInput); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.