Skip to content

Initial commit for flat_map and flat_multimap#309

Draft
mintel1 wants to merge 7 commits intomainfrom
flat_map_serialisation
Draft

Initial commit for flat_map and flat_multimap#309
mintel1 wants to merge 7 commits intomainfrom
flat_map_serialisation

Conversation

@mintel1
Copy link
Collaborator

@mintel1 mintel1 commented May 14, 2024

Initial discussion point for flat_map and flat_multimap. Would like to find out best test practice, plus how to include an actual implementation (from cppreference) as opposed to a boost include

@mintel1 mintel1 added question Further information is requested serialisation Issues related to serialisation labels May 14, 2024
@mintel1 mintel1 requested a review from Twon May 14, 2024 06:39
@Twon
Copy link
Owner

Twon commented May 14, 2024

There should be tests added here for these containers, but it make me realise that this test still need to be extended to support all associative containers (i.e. map, unorder_maps, etc):

TEMPLATE_TEST_CASE("Verify serialisation of sequence containers std::ranges", "[morpheus.serialisation.ranges.serialise.sequence_containers]",

Perhaps this should be deferring to Catch2's generator framework here: https://github.com/catchorg/Catch2/blob/devel/docs/generators.md

mintel1 and others added 2 commits May 14, 2024 18:00
…at_map.hpp

Co-authored-by: Antony Peacock <ant.peacock@gmail.com>
…at_multimap.hpp

Co-authored-by: Antony Peacock <ant.peacock@gmail.com>
@mintel1
Copy link
Collaborator Author

mintel1 commented May 14, 2024

Will take a look at the Catch2 Generator framework thanks.
I haven't used any of the Catch frameworks before but have heard good things

@Twon
Copy link
Owner

Twon commented May 19, 2024

The conformance header should have a simple test to exercise and demonstrate the abstraction over the std and boost types work uniformly, see an example with Date here:

TEST_CASE("Ensure date library is supported and working", "[morpheus.conformance.date]")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

question Further information is requested serialisation Issues related to serialisation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants