Draft
Conversation
Twon
reviewed
May 14, 2024
libraries/core/src/morpheus/core/serialisation/adapters/std/flat_map.hpp
Outdated
Show resolved
Hide resolved
Twon
reviewed
May 14, 2024
libraries/core/src/morpheus/core/serialisation/adapters/std/flat_multimap.hpp
Outdated
Show resolved
Hide resolved
Owner
|
There should be tests added here for these containers, but it make me realise that this test still need to be extended to support all associative containers (i.e. map, unorder_maps, etc): Perhaps this should be deferring to Catch2's generator framework here: https://github.com/catchorg/Catch2/blob/devel/docs/generators.md |
…at_map.hpp Co-authored-by: Antony Peacock <ant.peacock@gmail.com>
…at_multimap.hpp Co-authored-by: Antony Peacock <ant.peacock@gmail.com>
Collaborator
Author
|
Will take a look at the Catch2 Generator framework thanks. |
Twon
reviewed
May 19, 2024
Owner
|
The conformance header should have a simple test to exercise and demonstrate the abstraction over the |
Co-authored-by: Antony Peacock <ant.peacock@gmail.com>
…o flat_map_serialisation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial discussion point for flat_map and flat_multimap. Would like to find out best test practice, plus how to include an actual implementation (from cppreference) as opposed to a boost include