Draft
Conversation
…eplacing lots of rapidjson text in the yaml version. Need to recognise ryml headers
Collaborator
Author
|
I will of course happily adhere to all of the coding guidelines (such as removal of commented out code etc) once I get things to a more presentable state. Also wondering if it could be possible to raise a PR without kicking off the checks, if I know it's going to fail anyway? |
Owner
Yes, you can mark this as a draft request. It's possible to change an existing PR to a draft one (just Google for how): https://github.blog/2019-02-14-introducing-draft-pull-requests/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit just to get things up and running. This does not compile and has no rapidyaml - specific code yet.
What I've done is attempt to
At the moment, my main issues are that
If I can get the config correct so that ryml is recognised, I can start to look at how that lib differs from rapidjson and write code accordingly. It also means I could start looking at other potential serialisations :-)
Thanks!