Conversation
- Update minimum Ruby version from 2.0 to 2.7 - Add modern development dependencies (bundler >= 2.0, rake ~> 13.0, rspec ~> 3.10) - Add simplecov_json_formatter for qlty coverage integration - Include C extension files in gem package - Configure native extension build system
- Remove extra whitespace and blank lines - Maintain simplecov and rspec test dependencies
- Implement native C extension using Ruby's internal C API - Add extensive safety warnings at build, load, and runtime - Require THAW_BUILD_NATIVE=true environment variable to compile - Include comprehensive documentation about risks and platform issues - Provide ThawNative module with version and safety information⚠️ WARNING: This extension is extremely dangerous and will likely crash modern Ruby versions. It's provided only for users who understand the risks and have no other alternatives.
- Add qlty integration with JSON coverage formatter - Include StringIO for test warning capture - Gracefully handle missing JSON formatter dependency - Configure multi-format coverage output (HTML + JSON)
- Add comprehensive CI workflow with multi-Ruby testing (2.7-3.3) - Include security scanning with bundle audit - Add qlty integration for code quality and coverage - Implement automated gem building with artifact storage - Add manual release workflow with safety confirmations - Support GitHub Packages deployment with production environment controls
- Clarify that gem supports Ruby 2.7+ through multiple implementations - Document three modes: safe (default), native C extension, Ruby fallback - Switch from Code Climate to qlty badges and links - Fix incorrect GitHub repository references (active_record-framing → thaw) - Correct typos in installation section - Add comprehensive warnings about dangers of all implementations - Emphasize Object#dup as the strongly recommended alternative
- Bump version to 0.2.0 for modernized release - Add post-install warning message displayed on gem installation - Update summary and description with danger warnings - Provide clear guidance toward Object#dup alternative - Ensure all RubyGems users see prominent safety notices
- Test across Linux, Windows, and macOS - Maintain Ruby 2.7-3.3 testing on all platforms - Optimize coverage/RuboCop to run only on Ubuntu + Ruby 3.3 - Ensure gem works reliably across different operating systems - Total test matrix: 15 combinations (3 OS × 5 Ruby versions)
voltechs
force-pushed
the
develop
branch
6 times, most recently
from
796f3dd to
c98d72a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completely modernizes the
thawRuby gem while maintaining backward compatibility and adding extensive safety measures. The gem now supports Ruby 2.7+ through multiple implementations with comprehensive warnings about the dangers of unfreezing objects.Key Changes
Object#dupImplementation Modes
The gem now supports three modes:
THAW_BUILD_NATIVE=true- Attempts to support modern Ruby (has compilation issues)THAW_FORCE_LOAD=true- Original dangerous implementation (crashes Ruby 2.7+)Safety Features
Object#dupinsteadBreaking Changes
Test Coverage
Commits
Testing
All tests pass in safe mode across Ruby 2.7-3.3. The dangerous functionality is deliberately not tested in CI to prevent crashes, but extensive warnings ensure users understand the risks.
Compatibility
This maintains backward compatibility for users who explicitly opt-in to dangerous functionality while providing a safe default experience for new users.
Object#dupinstead.