fixed typecast of values, as i.e. a value of 012 was parsed to 10 #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have been facing a similar issue, including some hashes (e.g. @TwP what are your thoughts on this PR? It would be great to get this merged into mainline. |
|
Running into this issue too, @TwP would you mind reviewing @larskuhnt solution? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I was facing the issue that a value of 012 was parsed via
Integer("012")and returned the integer value10. As an integer by definition may not have a leading zero, values starting with 0 will be parsed as either a float or a string.Thanks for the good work
Lars