Skip to content

Conversation

@lizmat
Copy link
Collaborator

@lizmat lizmat commented Aug 3, 2025

  • Make sure we get the latest Slang::Tuxic / File::Temp
  • Remove test dependency on Test::Meta: if the meta is wrong, you will know, no reason to go to lengths at checking that after all the other tests
  • made $VERSION a constant, because it is

@lizmat
Copy link
Collaborator Author

lizmat commented Aug 3, 2025

Argh.... looks like I based it off a stale repo

- Make sure we get the latest Slang::Tuxic / File::Temp
- Remove test dependency on Test::Meta: if the meta is wrong, you
  will know, no reason to go to lengths at checking that after all
  the other tests
- made $VERSION a constant, because it is
@lizmat
Copy link
Collaborator Author

lizmat commented Aug 3, 2025

Fixed now

Copy link
Collaborator

@JJ JJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test::Meta is deprecated?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not as such at the moment, no. But in the SBOM world we're going to need much more info in the META6.json to be able to create CE certifiable SBOMs, and in my opinion it should be part of any standard publication process.

@JJ
Copy link
Collaborator

JJ commented Aug 3, 2025

  • Remove test dependency on Test::Meta: if the meta is wrong, you will know, no reason to go to lengths at checking that after all the other tests

Maybe move it up to the first position? I'm never confortable with removing a test...

@lizmat
Copy link
Collaborator Author

lizmat commented Aug 3, 2025

Maybe move it up to the first position? I'm never confortable with removing a test...

Thing is that if there is an error in the META6.json, a module won't even execute nowadays.

@Tux Tux merged commit 0dd4ac1 into master Aug 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants