Skip to content

fix Base.copy definitions#1339

Merged
penelopeysm merged 2 commits intomainfrom
py/sa
Mar 27, 2026
Merged

fix Base.copy definitions#1339
penelopeysm merged 2 commits intomainfrom
py/sa

Conversation

@penelopeysm
Copy link
Copy Markdown
Member

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 27, 2026

Benchmark Report

  • this PR's head: c9a636b7775fcbf68d8a1619e7899d2133a5eff3
  • base branch: 1285327a0230030f286d64ce2329444729b97e30

Computer Information

Julia Version 1.11.9
Commit 53a02c0720c (2026-02-06 00:27 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 4 × AMD EPYC 7763 64-Core Processor
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Benchmark Results

┌───────────────────────┬───────┬─────────────┬────────┬───────────────────────────────┬────────────────────────────┬─────────────────────────────────┐
│                       │       │             │        │       t(eval) / t(ref)        │     t(grad) / t(eval)      │        t(grad) / t(ref)         │
│                       │       │             │        │ ─────────┬──────────┬──────── │ ───────┬─────────┬──────── │ ──────────┬───────────┬──────── │
│                 Model │   Dim │  AD Backend │ Linked │     base │  this PR │ speedup │   base │ this PR │ speedup │      base │   this PR │ speedup │
├───────────────────────┼───────┼─────────────┼────────┼──────────┼──────────┼─────────┼────────┼─────────┼─────────┼───────────┼───────────┼─────────┤
│               Dynamic │    10 │    mooncake │   true │   289.77 │   285.95 │    1.01 │   7.76 │    8.27 │    0.94 │   2249.71 │   2365.85 │    0.95 │
│                   LDA │    12 │ reversediff │   true │  2703.91 │  3848.07 │    0.70 │   4.46 │    4.09 │    1.09 │  12064.05 │  15728.29 │    0.77 │
│   Loop univariate 10k │ 10000 │    mooncake │   true │ 31336.61 │ 31315.60 │    1.00 │   6.57 │    6.38 │    1.03 │ 205797.15 │ 199787.13 │    1.03 │
├───────────────────────┼───────┼─────────────┼────────┼──────────┼──────────┼─────────┼────────┼─────────┼─────────┼───────────┼───────────┼─────────┤
│    Loop univariate 1k │  1000 │    mooncake │   true │  3175.90 │  3184.86 │    1.00 │   6.54 │    6.34 │    1.03 │  20780.39 │  20180.94 │    1.03 │
│      Multivariate 10k │ 10000 │    mooncake │   true │ 30659.96 │ 31078.48 │    0.99 │  10.29 │   10.27 │    1.00 │ 315467.53 │ 319218.19 │    0.99 │
│       Multivariate 1k │  1000 │    mooncake │   true │  3255.41 │  3313.94 │    0.98 │   9.65 │    9.67 │    1.00 │  31410.88 │  32032.64 │    0.98 │
├───────────────────────┼───────┼─────────────┼────────┼──────────┼──────────┼─────────┼────────┼─────────┼─────────┼───────────┼───────────┼─────────┤
│ Simple assume observe │     1 │ forwarddiff │  false │     0.88 │     0.88 │    1.00 │  10.52 │   10.48 │    1.00 │      9.23 │      9.23 │    1.00 │
│           Smorgasbord │   201 │ forwarddiff │  false │   956.26 │   950.75 │    1.01 │  69.28 │   72.13 │    0.96 │  66244.96 │  68573.55 │    0.97 │
│           Smorgasbord │   201 │      enzyme │   true │  1286.98 │  1298.21 │    0.99 │   4.89 │    4.86 │    1.01 │   6290.46 │   6308.33 │    1.00 │
├───────────────────────┼───────┼─────────────┼────────┼──────────┼──────────┼─────────┼────────┼─────────┼─────────┼───────────┼───────────┼─────────┤
│           Smorgasbord │   201 │ forwarddiff │   true │  1297.45 │  1323.72 │    0.98 │  68.92 │   65.97 │    1.04 │  89425.64 │  87323.26 │    1.02 │
│           Smorgasbord │   201 │    mooncake │   true │  1282.49 │  1288.18 │    1.00 │   4.71 │    4.76 │    0.99 │   6038.68 │   6131.41 │    0.98 │
│           Smorgasbord │   201 │ reversediff │   true │  1280.49 │  1290.68 │    0.99 │ 132.83 │  129.71 │    1.02 │ 170089.24 │ 167418.47 │    1.02 │
├───────────────────────┼───────┼─────────────┼────────┼──────────┼──────────┼─────────┼────────┼─────────┼─────────┼───────────┼───────────┼─────────┤
│              Submodel │     1 │    mooncake │   true │     0.88 │     0.88 │    1.00 │  26.87 │   28.92 │    0.93 │     23.58 │     25.41 │    0.93 │
└───────────────────────┴───────┴─────────────┴────────┴──────────┴──────────┴─────────┴────────┴─────────┴─────────┴───────────┴───────────┴─────────┘

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.13%. Comparing base (1285327) to head (c9a636b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1339      +/-   ##
==========================================
+ Coverage   77.93%   78.13%   +0.19%     
==========================================
  Files          50       50              
  Lines        3585     3590       +5     
==========================================
+ Hits         2794     2805      +11     
+ Misses        791      785       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@penelopeysm penelopeysm merged commit 38ca13a into main Mar 27, 2026
22 checks passed
@penelopeysm penelopeysm deleted the py/sa branch March 27, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant