-
Notifications
You must be signed in to change notification settings - Fork 5
Phase 0 Medford validation functionality #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alexisylee
wants to merge
31
commits into
dev
Choose a base branch
from
dev_validator
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lidation. accidentally got the code reformatted so please ignore those changes
…kenly being marked as required issue was that even if marked as optional, pydantic still requires them to be marked as equals None
…es. Also, removed printed output from tests.
…ring leading whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new file medfordValidator.py contains an implementation of the phase 0 Medford validator that reads an .mvd file (validator rules file) and validates tokens in a .mfd file according to the defined rules.
Current implementation uses a hardcoded validator filename — this will need to be updated based on project decisions.
The new medfordValidator module includes validation checks for:
Basic relational logic: less than, greater than
Format validation: email format, URI format
Other foundational checks to support token validation