Add BagIt functionality and BagIt test suite #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvacouch
reviewed
Jul 17, 2025
src/MEDFORD/objs/bagitHandler.py
Outdated
| with open(bag_info_path, 'w', encoding='utf-8') as f: | ||
| for line in bag_info_lines: | ||
| f.write(line + '\n') | ||
|
|
There was a problem hiding this comment.
Run Flake8 on all files to catch inconsistent formatting.
alvacouch
reviewed
Jul 17, 2025
src/MEDFORD/objs/linecollections.py
Outdated
|
|
||
| def get_content(self, resolved_macros: Dict[str, str]) -> str : | ||
| out = self.headline.get_content(resolved_macros) | ||
| # print(f"Call stack: {traceback.format_stack()}", file=sys.stderr) |
alvacouch
reviewed
Jul 17, 2025
| assert L is not None | ||
| confirmed_lines.append(L) | ||
|
|
||
| lc : LineCollector = LineCollector(confirmed_lines) |
There was a problem hiding this comment.
Does this deal with the issue of the LineCollector TODO comment seen previously?
|
In general, now would be a good time to delete any file that became unused. Flake8 will tell you. |
…kenly being marked as required issue was that even if marked as optional, pydantic still requires them to be marked as equals None
…es. Also, removed printed output from tests.
…ring leading whitespace
alexisylee
force-pushed
the
dev_testsuite
branch
from
94a60a9 to
2a11c03
Compare
infispiel
reviewed
Aug 8, 2025
src/MEDFORD/medford.py
Outdated
| write_json=args.write_json, | ||
| output_path="." | ||
| ) | ||
| >>>>>>> 90ea795 (halfway done with bagit handler) |
infispiel
reviewed
Aug 8, 2025
src/MEDFORD/medford.py
Outdated
| json.dump(self.dict_data, f, indent=2) | ||
| combined_data = process_blocks_to_dict(self.blocks) | ||
| json.dump(combined_data, f, indent=2) | ||
| hello |
Member
|
Have you checked if the medford command actually works with your changes? I've already found 2 locations that should cause the entire program not to compile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds BagIt validation and compilation functionalities as well as a test suite testing it.
Included:
BagIt validator that validates: if file root exists, if file referenced exists, that all files in FileRoot must have corresponding tags, and if all files are readable
BagIt compiler that creates a .zip with: metadata files, manifest.txt, bag-info.txt, metadata.mfd, and metadata.json files
Test cases for all data provenance tokens and error cases.
Input .mfd files for testing.
Expected output Bags for validation
Test runner script and setup utilities
Run the test suite with python3 bagit_testsuite/bagit_testsuite_driver.py.