Skip to content

Adding very strong password #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TsuyoshiUshio wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adding very strong password #18

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9db8b4
Adding very strong password.
TsuyoshiUshio Sep 18, 2019
8de72d1
Update the strong password
TsuyoshiUshio Sep 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions VulnerableApplication/Global.asax.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,6 @@ protected void Application_Start()
RouteConfig.RegisterRoutes(RouteTable.Routes);
BundleConfig.RegisterBundles(BundleTable.Bundles);
}
public const string Password = "abc";
}
Copy link
Copy Markdown
Owner Author

@TsuyoshiUshio TsuyoshiUshio Sep 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CODE_SMELL

3 more lines of code need to be covered by tests to reach the minimum threshold of 65.0% lines coverage.
See details

Copy link
Copy Markdown
Owner Author

@TsuyoshiUshio TsuyoshiUshio Sep 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CODE_SMELL

7 more comment lines need to be written to reach the minimum threshold of 25.0% comment density.
See details

Copy link
Copy Markdown
Owner Author

@TsuyoshiUshio TsuyoshiUshio Sep 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CODE_SMELL

Add or update the header of this file.
See details

Copy link
Copy Markdown
Owner Author

@TsuyoshiUshio TsuyoshiUshio Sep 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VULNERABILITY

'password' detected in this expression, review this potentially hardcoded credential.
See details

Copy link
Copy Markdown
Owner Author

@TsuyoshiUshio TsuyoshiUshio Sep 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CODE_SMELL

Change this constant to a 'static' read-only property.
See details

Copy link
Copy Markdown

@rguthriemsft rguthriemsft Sep 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/falsepositive

Copy link
Copy Markdown
Owner Author

@TsuyoshiUshio TsuyoshiUshio Sep 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is already resolved or confirmed.

Copy link
Copy Markdown

@rguthriemsft rguthriemsft Sep 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/falsepositive

Copy link
Copy Markdown
Owner Author

@TsuyoshiUshio TsuyoshiUshio Sep 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is already resolved or confirmed.

}