This repository was archived by the owner on Nov 30, 2023. It is now read-only.
Added feat to write to different output file.#36
Closed
Symbitic wants to merge 1 commit intoTrySound:masterfrom
Symbitic:master
Closed
Added feat to write to different output file.#36Symbitic wants to merge 1 commit intoTrySound:masterfrom Symbitic:master
Symbitic wants to merge 1 commit intoTrySound:masterfrom
Symbitic:master
Conversation
Owner
|
Hi, thanks for this. Though I think such feature fits better into pipeline and may spend less time than duplicated build TrySound/rollup-plugin-uglify#61 |
Author
|
Can you please explain how that pull request relates to this? |
Owner
|
Build itself will not be duplicated. Only generation will be called twice with this feature. |
Author
|
I think I understand. So I'm gonna close this. Thanks for your answers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know in issue #29 you said you didn't want this feature added, but please hear me out.
I added this because I'm trying to port Babylon.js to Rollup. The core module alone takes 2 minutes for the UMD bundle, and the minified UMD bundle takes another 2 min and 30 seconds. I can majorly cut that down by only generating the bundle once and then just writing normal and minified to different files.
The only change is that
terser({ filename: "custom.js" })will write to "custom.js" and leave the regular output file untouched. It's literally just a few extra lines of code (just adding an extra promise at the end), and all tests still pass.Please consider this.