Skip to content

Conversation

@bitmold
Copy link
Collaborator

@bitmold bitmold commented Nov 29, 2025

In Quiet, leveldown was replaced with a (now pretty outadted) version of classic_level a few years ago.

This PR removes some unsued json+js, as well as unused leveldown binaries for mac + windows + linux , hopefully simplifying some of the confusion around Quiet's leveldb integration.

Am able to run npm run start:desktop and upload images just fine without these.

You'll notice that binaries for iOS and Android still exist on this PR, that's because similar work to get rid of leveldown on mobile is in my mobile PR #3011.

Haven't tested this locally on Windows like i have linux + mac..., but the Windows CI seems fine

@bitmold bitmold force-pushed the no-desktop-leveldown branch from 05e0c3f to 986f82f Compare November 29, 2025 05:29
@bitmold bitmold requested a review from islathehut December 1, 2025 20:31
@bitmold
Copy link
Collaborator Author

bitmold commented Dec 22, 2025

cc @holmesworcester this PR doesn't do anything other than remove unused leveldown DB binaries (that are named very similarly to binaries Quiet actually uses and of course needs to function - the leveldown bins being deleted here were in fact confusingly replaced with classic-level binaries, which sound older because of the classic but actually in fact are the newer ones used by the app.....) --- I spent a nontrivial amount of time trying to make sense of the different leveldown/classic-level binaries when working on #3011. once i realized i eventually needed to rebuild classic-level on android, i wasted time not knowing which binary i'd need to swap out for my modified one, etc.

once this is merged, other devs won't have to waste time trying to wrap their head around which bin is doing what like i did

@bitmold
Copy link
Collaborator Author

bitmold commented Jan 23, 2026

Closing, just threw these 2 commits on this forgotten PR onto the related #3092

@bitmold bitmold closed this Jan 23, 2026
@bitmold bitmold deleted the no-desktop-leveldown branch January 23, 2026 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant