feat(3058): Allow overriding decryption keys on keys* methods, add createLockbox method to team, add self-assign role method #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
adrastaea
requested changes
Jan 16, 2026
packages/auth/src/team/Team.ts
Outdated
|
|
||
| /** Give yourself a role */ | ||
| public addMemberRoleToSelf = (roleName: string, decryptionKeys: KeysetWithSecrets) => { | ||
| assert(this.selfAssignRoles.includes(roleName), `Cannot self-assign role ${roleName}`) |
Collaborator
There was a problem hiding this comment.
I think this is the wrong place to do this. This is essentially trusting people to self moderate. I think the correct place to do this is in membershipResolver:membershipRules so that peers can enforce the rules themselves and throw out invalidated links.
Collaborator
Author
There was a problem hiding this comment.
I'm gonna do it there, too, that piece is just more complicated and this blocks the lockbox creation, too.
Collaborator
Author
There was a problem hiding this comment.
I wanted to take more time to look at the implications of blocking updates to the chain on these sorts of checks but didn't wanna delay being able to test self-assigns.
islathehut
changed the title
islathehut
force-pushed
the
feat/3058-allow-key-override
branch
from
375c8ec to
9997e86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.