[Solo] Add anchor link to content headings #2
+160
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clicking heading link icon now copies URL to clipboard
Move local anchor link feature (heading copy-to-clipboard buttons) into custom.css and custom.js to minimize merge conflicts when rebasing from upstream TryGhost/Solo. - Create assets/css/custom.css with anchor link styling - Create assets/js/custom.js with anchor link functionality - Add @import "custom.css" to screen.css - Update gulpfile.js to conditionally include custom.js in build - Remove customizations from screen.css and main.js 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| anchor.addEventListener('click', async (e) => { | ||
| e.preventDefault(); | ||
| const url = new URL(window.location.href); | ||
| url.hash = heading.id; |
There was a problem hiding this comment.
Anchor links fail for headings without IDs
The code sets url.hash = heading.id without checking if the heading has an id attribute. If a heading lacks an id, the copied URL will end with just #, which won't navigate to the intended section when shared. The anchor button is still added to such headings, potentially confusing users who expect the copied link to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds anchor links to post headings, enabling you to share deep links to your articles so that people can navigate directly to the relevant content you're trying to share. The anchor link is hidden until you hover over (or touch) the heading, and once it's displayed you can copy the link to share it with someone else.
Here's a demo of what it looks like:
solo-heading-anchor-demo.mp4
And I'm hosting a live demo on my personal website which you can see here: https://evanw.com/2021-my-year-in-reading/#the-stats
This feature is really useful when you write longer-form content and want to share a specific section with someone, or if you're trying to link to specific sections within your own content.
If there are any questions or concerns about this change, please let me know. Thanks for the consideration!
Note
Introduces shareable deep links for article sections.
.gh-content h1–h6inassets/built/main.min.js; on click copies the heading URL to clipboard and shows tooltip feedback.anchor-linkstyles and tooltip/animation rules inassets/built/screen.css; ensures visibility on hover/touch.gitignoreextended (e.g.,robots.txt,node_modules/, yarn files)Written by Cursor Bugbot for commit 455ecc1. This will update automatically on new commits. Configure here.