Skip to content

added url transform to default email content #25812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cmraible merged 1 commit into from
Jan 8, 2026
Merged

added url transform to default email content #25812

cmraible merged 1 commit into from
Jan 8, 2026
+31 −3

Conversation

@troyciesco
Copy link
Contributor

@troyciesco troyciesco commented Jan 8, 2026

added url transform to default email content

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 8, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • 6.x

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

troyciesco
troyciesco commented Jan 8, 2026
View reviewed changes
ghost/core/test/integration/services/member-welcome-emails.test.js
assert.equal(entriesAfterJob.length, 0);
});

it('transforms __GHOST_URL__ placeholders to actual site URL in default templates', async function () {
Copy link
Contributor Author

@troyciesco troyciesco Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was about to delete this test because it's only for the default template but i see we have some other default template related ones, so i'll keep it even tho it's temporary

@troyciesco troyciesco requested a review from cmraible January 8, 2026 13:48
@cmraible cmraible merged commit 1a03e61 into chris-ny-890-test-sending-welcome-emails-to-black-hole-in-production-at Jan 8, 2026
36 of 38 checks passed
@cmraible cmraible deleted the st_add-url-transform branch January 8, 2026 22:57
cmraible pushed a commit that referenced this pull request Jan 8, 2026
@troyciesco @cmraible
added url transform to default email content (#25812)
84c77db 
added url transform to default email content
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmraible cmraible Awaiting requested review from cmraible

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@troyciesco @cmraible