Release 2.3.1: The Teapot Moment #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Why This Change Was Made - Avoid the magic-number anti-pattern for 418 by exposing a semantic constant (`teapot`) for readability - Close out GitHub issue #38 by making “I’m a teapot” as easy to write as `ok` and `not_found` ## What Was Changed - Added `teapot = 418` to `src/dream/http/status.gleam` with RFC 2324 documentation - Bumped Dream to 2.3.1 and updated `CHANGELOG.md`, `README.md`, and added `releases/release-2.3.1.md` ## Note to Future Engineer - This is intentionally tiny and backwards-compatible; if it breaks something, the universe is trying to tell you something about your assumptions - If you ever feel tempted to type `418` again, take a deep breath, whisper “semantic clarity”, and choose `teapot` like the evolved being you are
## Why This Change Was Made - The pre-commit/build steps regenerated the module manifest, leaving the working tree dirty - Keeping generated manifests committed prevents confusing diffs for the next person and keeps module builds reproducible ## What Was Changed - Updated `modules/mock_server/manifest.toml` to reflect the newer Dream dependency range/version resolution ## Note to Future Engineer - Yes, this is a commit about a generated file. No, you are not hallucinating. - If you’re annoyed, redirect that energy into making the generator deterministic (or into brewing coffee… unless you’re a teapot).
dcrockwell
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the Dream 2.3.1 release PR.
Why
418is a magic number; named status constants make code clearerteapotinstead of418What
teapot(418) as a named HTTP status constant (documented per RFC 2324)dream_mock_servermanifest so builds don’t leave a dirty treeHow
pub const teapot = 418insrc/dream/http/status.gleamgleam.toml,CHANGELOG.md,README.mdreleases/release-2.3.1.md