Allow YouTube Music tracks in the queue#8
Open
samhatts wants to merge 3 commits intofeature/rk/searchfrom
Open
Allow YouTube Music tracks in the queue#8samhatts wants to merge 3 commits intofeature/rk/searchfrom
samhatts wants to merge 3 commits intofeature/rk/searchfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
ItemIdandTrackUri, decode URI components, and extract service-specific references using a regex that matchesspotify,youtube, andytmusicURIs inQueueProviderand callgetTrackwith a detected service id.YouTubeMusic = 233to theServicesenum and detect service id fromsidquery param or by matchingyoutube|ytmusicin URIs inQueueProvider.SonosContextto accept an optionalserviceparameter and prepend the service to cache keys so metadata is cached and retrieved per service, and use the providedservicewhen callingsonos.GetItemMetadata/GetMetadata.TN_Trackobjects and included in the UI.Testing
Codex Task