-
Notifications
You must be signed in to change notification settings - Fork 0
Release 0.4.0: 6-Decimal Token Support and Dynamic Decimal Handling #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dacarva
wants to merge
40
commits into
develop
Choose a base branch
from
001-erc20-decimals
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
065ab58
Remove deprecated specifications and documentation for delisted marke…
dacarva bc6ca29
Fix Core tropykus tests to work with Anvil forking Rootstock Mainnet.…
dacarva bb1d6a3
Refactor getAllMarketsInstances method in Comptroller to improve perf…
dacarva a718a49
Checkpoint. Fixing market tests
dacarva 7656759
Enhance README with test execution instructions and update market tes…
dacarva 2845a61
Refactor Unitroller tests to deploy fresh instances for improved reli…
dacarva e81d280
Update deprecation-config.js and related tests to reflect accurate ma…
dacarva e922b3d
Fix Quickstart validation test by adding error handling to ensure qui…
dacarva 88c605d
Enhance README and test suite documentation with critical Anvil node …
dacarva 2e2affc
Implement support for 6-decimal ERC20 tokens with 8-decimal price ora…
dacarva f8f77d8
Complete initial project setup by verifying existing structure and im…
dacarva 1e5d8ce
Implement decimal detection for oracle adapters in PriceOracle. Add `…
dacarva 7abb4c2
Enhance support for ERC20 tokens by integrating 6-decimal tokens with…
dacarva a021779
Decimals utils completed
dacarva 0dbb21e
Integrate PriceOracle into the Tropykus package by importing it in `i…
dacarva e396157
Checkpoint. About to start priceoracle tasks
dacarva 810012b
Update documentation to reflect changes in token integration, emphasi…
dacarva e7f09dc
Implement integration tests for 6-decimal token operations in `02-mar…
dacarva f65f4f8
Added mockPriceOracleAdapter for USDT0
dacarva a9456f8
Refactor balanceOfUnderlying and mint methods in CErc20 and Market cl…
dacarva 40bcd91
Refactor balanceOfUnderlyingInWallet method in CErc20 to use async/aw…
dacarva b3500ad
Refactor borrowBalanceCurrent method in Market class to use async/awa…
dacarva dbf1636
Refactor CErc20 class to eliminate hardcoded factor and implement dyn…
dacarva 4c196c9
Add redeem method to CErc20 class for token redemption with dynamic d…
dacarva d69e368
T021 completed. Token Transfers updated
dacarva 71a3a17
Refactor Market and CErc20 classes to implement dynamic decimal handl…
dacarva f746b88
Update tests in 02-markets.spec.js to implement multi-market operatio…
dacarva 929e5b5
Enhance Comptroller and Market classes to support dynamic decimal han…
dacarva e8c8691
Chekpoint. Fixing getTotalSupply
dacarva 12c6bb8
Refactor getTotalSupplyInAllMarkets method in Comptroller to streamli…
dacarva 54c4251
Fixing tests
dacarva 35ee921
Refactor getTotalBorrowsInAllMarkets method in Comptroller to improve…
dacarva dc635a1
Enhance Market class to improve cToken calculation by implementing dy…
dacarva fc63d13
Refactor tests in 02-markets.spec.js to enable previously skipped tes…
dacarva 6a882af
Update CHANGELOG for version 0.4.0, adding support for 6-decimal ERC2…
dacarva a76dacc
Deleted unnecesary files
dacarva 30b2d87
Deleted Specs
dacarva 422a121
Refactor project structure and update package names to align with new…
dacarva 81a754f
Update README and .gitignore for Tropykus project. Remove deprecated …
dacarva 5a50efa
Update version to 0.4.1-alpha in package.json and lerna.json. Enhance…
dacarva File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| { | ||
| "version": "0.2.17", | ||
| "version": "0.4.1-alpha", | ||
| "command": { | ||
| "init": { | ||
| "exact": true | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test instructions and USDT0 clarifications read well; just fix the markdownlint blockquote warning.
The new “Running Tests” section and the Anvil notes are clear and match the new Anvil-based test setup, and the USDT0 vs kUSDT decimal explanation later in the README is very helpful.
markdownlint (MD028) is flagging a “Blank line inside blockquote” around the Anvil notes (lines 39–41). There appears to be an empty blockquote line between the two quoted notes. You can fix this by either:
>line in between.Content-wise this section is good; this is just to keep markdownlint happy.
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
40-40: Blank line inside blockquote
(MD028, no-blanks-blockquote)
🤖 Prompt for AI Agents
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the blank line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NataliaMunozC, here's the fix for the markdownlint warning. You need to remove the empty line between the two blockquote notes.
Current code (with the blank line issue):
Fixed version (remove the empty line between blockquotes):
Alternatively, you could merge them into a single blockquote with a blank line inside (but this is less clear):
I recommend the first approach (consecutive blockquotes with no empty line between them) as it's cleaner and satisfies markdownlint.