Aplicando sugestões na ficha#3
Open
GustavoOliani wants to merge 9 commits intoTrojanHorse-bot:masterfrom
Open
Conversation
I fragmanted the layout files on "fichaGuess", so it would be easier to find, refactor and implement new features; Now the "rolagem" field is automatic calculated and I added a new edit called "bonus" to write all the bonus on the skill roll.
…o rrpgfirecast-master
…o rrpgfirecast-master
Separando as abas da ficha em arquivos diferentes
Separando os arquivos e refatorando o código.
Criado uma classe de estilo, para os atributos Comentado o código para calculo automático do campo de rolagem nas skills e o campo de bônus
Criada uma pasta para conter os dataLinks mais extensos Refeito o dataLink dos atributos, de forma a deixar mais limpa a visualização do código Retirado o defaultValue dos anéis, uma vez que eles sempre calculam o valor quando existem mudanças no campo de atributos.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Esses são os pontos os quais consegui alterar até o momento: