Open
Conversation
Getting the ball rolling, followed bukkit impl as a guide
Most is pulled from bukkitCommands and modified!
The caveat is that we always return success (for now)
fix typo
One small caveat SpongeCommandManager has a method commented out due to some type erasure issues. Updated javadocs in some areas.
LichtHund
commented
May 24, 2022
settings.gradle.kts
Outdated
| } | ||
|
|
||
| include("test-module") | ||
| include("Spawn-Protection") |
Member
Author
There was a problem hiding this comment.
Make sure you don't include this.
minecraft/mc-common/build.gradle.kts
Outdated
| id("cmds.library-conventions") | ||
| } | ||
|
|
||
| repositories {} |
minecraft/sponge/build.gradle.kts
Outdated
| } | ||
|
|
||
| repositories { | ||
| maven { |
Member
Author
There was a problem hiding this comment.
Replace with maven("https://repo.spongepowered.org/maven").
| * {@inheritDoc} | ||
| */ | ||
| @Override | ||
| public void execute(@NotNull Runnable command) { |
Member
Author
There was a problem hiding this comment.
Don't forget the final.
remove unused plugin and repo block in gradle condense sponge maven repo make Runnable final
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.