Skip to content

Dynamic Attendance Creation#39

Merged
Rohaansandhu merged 2 commits intomainfrom
dynamic-attendance
Mar 11, 2026
Merged

Dynamic Attendance Creation#39
Rohaansandhu merged 2 commits intomainfrom
dynamic-attendance

Conversation

@Rohaansandhu
Copy link
Contributor

@Rohaansandhu Rohaansandhu commented Mar 8, 2026

Tracking Info

Resolves #38

Changes

  • Moved attendance creation call to the getSession endpoint
  • Put session attendance create function in attendance controller
  • Added date check on the backend to ensure future dates don't have attendances created
  • Fixed frontend date picking to be compatible with UTC dates in the DB (previously was assuming dates in the DB were in local time)

Testing

  • Tested locally and on the branch PR
  • Test workflow:
  • create new section w/ students
  • create a bunch of sessions (some in the past, some in the future)
  • check db to ensure that attendance objects weren't created on session creation
  • then, use frontend UI and date picker calendar to select sessions in the past/future
  • verify that attendances are created automatically when you click a session
  • verify that old session attendances aren't overridden
  • verify that future session attendance objects aren't created

Confirmation of Change

Verify attendance objects are created when session is loaded:
Screenshot 2026-03-08 at 3 54 18 PM

Verify future sessions don't create unnecessary attendance objects:
Screenshot 2026-03-08 at 3 57 16 PM

Verify old attendance objects aren't overridden/replaced:
Screenshot 2026-03-08 at 3 58 22 PM

@github-actions
Copy link

github-actions bot commented Mar 8, 2026

Visit the preview URL for this PR (updated for commit a374fcd):

https://meemli-dev--pr39-dynamic-attendance-zdf9a9kt.web.app

(expires Sun, 15 Mar 2026 03:43:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 633a893569aee98f762f025e27aa080a469727e1

@Rohaansandhu Rohaansandhu marked this pull request as ready for review March 8, 2026 22:59
@Rohaansandhu Rohaansandhu requested a review from mraysu as a code owner March 8, 2026 22:59
@mraysu mraysu requested a review from Himir-Desai March 10, 2026 01:49
Copy link
Collaborator

@mraysu mraysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@Himir-Desai Himir-Desai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rohaansandhu Rohaansandhu merged commit efe9894 into main Mar 11, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dynamic Attendance Creation

3 participants