Conversation
|
please remove package.json and package-lock.json from the root directory (NOT |
|
Visit the preview URL for this PR (updated for commit d00e477): https://meemli-dev--pr36-frontend-account-act-e8oxglf1.web.app (expires Thu, 19 Mar 2026 07:28:01 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 633a893569aee98f762f025e27aa080a469727e1 |
mraysu
left a comment
There was a problem hiding this comment.
Great work on the login functionality.
For this PR, phoneNumber and assignedSections should have added backend functionality. Right now, both fields are being dropped when sending create user routes.
Update the database schema to include both fields, and make sure when assigning sections to update both the User and Section objects
There was a problem hiding this comment.
In the future, should convert the login component to a <form> so we can submit on enter, for a more intuitive login
| const [addOpen, setAddOpen] = useState(false); | ||
|
|
||
| return ( | ||
| <Page> |
There was a problem hiding this comment.
Unsure about the need for this <Page> component, since the styling in Page.module.css is empty
mraysu
left a comment
There was a problem hiding this comment.
Still a few issues, we need to make sure that when teachers are assigned to classes, the section objects also update with teacher assignment. Right now it is only updating the User object
Also, can you add an error message on invalid login
|
Also added error message for invalid login credentials |
|
my fault, was looking in the backend controller. should be gtg |







Tracking Info
Resolves #6
Changes
Testing
Confirmation of Change
Add Staff Modal:


Password Reset:

