Open
Conversation
…ags, separated volunteer type and event tags
…ilters when filters are applied
navyaa31
requested changes
Mar 10, 2026
Collaborator
navyaa31
left a comment
There was a problem hiding this comment.
I left a couple comments. One other thing is that "new" and "returning" are lower case rn but could you make them uppercase to match the other tags. Could you send screenshots to the designers and get their feedback as well?
| <span>Tags</span> | ||
| <span>Status</span> | ||
| <span> | ||
| <img src="/sort-arrow.svg" alt="" className={styles.sortIcon} /> |
Collaborator
There was a problem hiding this comment.
can we remove the sort arrows
Collaborator
There was a problem hiding this comment.
Could we have the frontend call the backend endpoints directly and remove this proxy route? you can refer to this PR where Michael removed proxies, and keep a look out for when its merged in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Testing
Tested with dummy data
How to test:
Run backend and frontend as normal. Use the team database, which has dummy data matching the new schemas.
Open http://localhost:3000/volunteers and apply any tags from the tab filter buttons.
Note: you may need to log out and log back in first. Then navigate to the volunteers page.
Confirmation of Change