Skip to content

Tag Filtering Type Separation#27

Open
YoChang410 wants to merge 7 commits intomainfrom
feat/tag-filter-types
Open

Tag Filtering Type Separation#27
YoChang410 wants to merge 7 commits intomainfrom
feat/tag-filter-types

Conversation

@YoChang410
Copy link
Contributor

@YoChang410 YoChang410 commented Mar 2, 2026

Changes

  • Changed Tags column on the table to Status, Event and Volunteer Type
  • Tag filter buttons show all tags of their type
  • Volunteer filtering now works with new Volunteer and Tag schema
  • Fixed misc. bugs with Tag fetching and Volunteer validation

Testing

Tested with dummy data

How to test:
Run backend and frontend as normal. Use the team database, which has dummy data matching the new schemas.
Open http://localhost:3000/volunteers and apply any tags from the tab filter buttons.
Note: you may need to log out and log back in first. Then navigate to the volunteers page.

  • Behavior when multiple filters are applied at once: AND” relation across filter types, and  “OR” relation within filter types. For example, if selected: Events “Charity Run” and “Holiday Drive”, and Status “returning”, it will return all volunteers that have “returning” AND (either charity run OR holiday drive)
  • 'Clear All' button should remove all filters

Confirmation of Change

Screenshot 2026-03-08 at 6 55 49 PM Screenshot 2026-03-08 at 6 56 00 PM Screenshot 2026-03-08 at 6 56 10 PM

@YoChang410 YoChang410 requested a review from navyaa31 as a code owner March 2, 2026 22:23
@YoChang410 YoChang410 marked this pull request as draft March 3, 2026 20:09
@YoChang410 YoChang410 marked this pull request as ready for review March 10, 2026 00:22
@navyaa31 navyaa31 assigned njbizzle and unassigned njbizzle Mar 10, 2026
@navyaa31 navyaa31 requested review from njbizzle and wmiq84 and removed request for CharlieSuarezRobles March 10, 2026 17:36
Copy link
Collaborator

@navyaa31 navyaa31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple comments. One other thing is that "new" and "returning" are lower case rn but could you make them uppercase to match the other tags. Could you send screenshots to the designers and get their feedback as well?

<span>Tags</span>
<span>Status</span>
<span>
<img src="/sort-arrow.svg" alt="" className={styles.sortIcon} />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove the sort arrows

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have the frontend call the backend endpoints directly and remove this proxy route? you can refer to this PR where Michael removed proxies, and keep a look out for when its merged in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants