Open
Conversation
Contributor
CharlieSuarezRobles
left a comment
There was a problem hiding this comment.
Good job on the code you wrote especially since it is quite involved! I think you made this pull request before I commited my changes, so could you get my changes and make that match the Figma design?
To be more specific, I changed the layout of the website so that the navBar and the padding on the top would match the design. This changed made the page I was working on match the design which you can see on the first image, but the others look a little off as you can see on the second and third images. So could you make these match the design?
Collaborator
|
+1 to Charlie's comments? Could you make style changes to match the Figma? You could also send screenshots to the designers to get feedback from them as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking Info
Resolves #13 (comment)
Changes
Testing
Confirmation of Change