Conversation
Member
Author
|
@RalphLipe can you take a look and let me know if you're happy with this change? I updated the constraints as we discussed and added a new test case based on the hand that was failing. |
RalphLipe
reviewed
Sep 11, 2025
Collaborator
There was a problem hiding this comment.
This looks correct. Not sure what the logic for the 3rd round of bidding will do with this. Should either end up in slam either in diamonds or probably in 6NT or maybe even 7NT. This is a huge hand.
RalphLipe
approved these changes
Sep 11, 2025
Collaborator
RalphLipe
left a comment
RalphLipe
left a comment
There was a problem hiding this comment.
This looks correct. Not sure what the logic for the 3rd round of bidding will do with this. Should either end up in slam either in diamonds or probably in 6NT or maybe even 7NT. This is a huge hand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #13