feat: implement is_valid_loan() with tests#31
Merged
jaykayudo merged 1 commit intoTrajectfi:mainfrom Jun 6, 2025
Merged
Conversation
Contributor
Author
|
@jaykayudo, kindly review and let me know if any adjustments are needed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implented the
is_valid_loanfunctionality based on stated requirements.Test Coverage Explanation:
Positive Case:
Negative Cases:
test_is_valid_loan_non_existent: Tests with a loan ID that doesn't exist
test_is_valid_loan_zero_id: Tests with loan_id = 0
test_is_valid_loan_mismatched_id: Tests when storage key doesn't match loan.id
test_is_valid_loan_uninitialized: Tests NOT_INITIALIZED status
Edge Cases:
test_is_valid_loan_repaid_status: Validates that REPAID loans are still considered valid
test_is_valid_loan_foreclosed_status: Validates that FORECLOSED loans are still considered valid
Type of Change
Checklist
Development Best Practices
Testing
Related Issues
Screenshots / Logs (if applicable)
Additional Context