feat: implement can_renegotiate_loan function#30
Conversation
added 2 commits
May 29, 2025 13:42
- Update IOperations interface to include `can_renegotiate_loan`.
- Add `can_renegotiate_loan` to prevent renegotiation on FORECLOSED or REPAID loans.
- Add unit tests covering active, repaid, foreclosed, and invalid loan ID scenarios.
- The `is_valid_loan` call is commented until the function is implemented in #23.
Author
|
Hello. Since the |
ghost
marked this pull request as ready for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the
can_renegotiate_loanfunction as described in issue #29.It determines whether a loan is eligible for renegotiation by ensuring that the loan is valid and active.
Type of Change
Checklist
Development Best Practices
Testing
Related Issues
Implement #29
Additional Context
The
is_valid_loan(loan_id)check is currently commented out and will be uncommented once issue #23 s implemented.