chore: major fixes for logic

[jaykayudo]

Description

Major Fixes for the logic component

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Contract optimization
• Documentation update
• Configuration change
• NFT collateralization flow change
• Loan terms or parameters modification

Checklist

Development Best Practices

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• [ xx] I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• New and existing tests pass locally with my changes

Security Considerations

• I have reviewed potential attack vectors introduced by these changes
• [xx] My code handles edge cases and ensures no funds can be lost
• Any updates to loan parameters or collateralization ratios have been thoroughly tested
• All state modifications are properly validated and authorized
• No centralization risks are introduced

Contract Specific Checks

• Contract changes are minimal and focused on the requirements
• Cairo-specific optimizations are implemented where possible
• Gas usage has been analyzed and optimized
• Contract interfaces maintain backwards compatibility (unless breaking change is intended)
• Starknet-specific considerations have been addressed

Testing

• Unit tests cover the new functionality
• Integration tests verify the changes work with other components
• Loan/collateral edge cases are tested (e.g., default scenarios, renegotiation)
• I have tested with realistic NFT values and token amounts

Implementation Notes

Related Issues

Environment & Deployment

• Starknet Network (testnet/mainnet):
• Cairo Version:
• Compiler Settings:

Screenshots / Logs (if applicable)

Additional Context