Skip to content

feat: create view_listed_assets ui#21

Closed
devJaja wants to merge 3 commits intoTrajectfi:mainfrom
devJaja:fix-#12
Closed

feat: create view_listed_assets ui#21
devJaja wants to merge 3 commits intoTrajectfi:mainfrom
devJaja:fix-#12

Conversation

@devJaja
Copy link

@devJaja devJaja commented May 2, 2025 •
edited
Loading

Description

Implement View Listed Asset UI
Follow Figma design

Related Issue

Fixes #
fix #12

Type of Change

  • New feature

How Has This Been Tested?

  • Unit tests
  • Integration tests
  • Manual tests
  • Other (please describe)

Checklist:

  • I have included screenshots or GIFs to demonstrate the changes (if applicable).

Screenshots (if applicable)

Uploading Screenshot from 2025-05-05 06-09-24.png…

Additional Notes

@DanielEmmanuel1 DanielEmmanuel1 self-requested a review May 2, 2025 21:47
DanielEmmanuel1
DanielEmmanuel1 requested changes May 2, 2025
View reviewed changes
Copy link
Collaborator

@DanielEmmanuel1 DanielEmmanuel1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole code is a mess
Shouldn't this be inside the dapp folder?

Why are u implementing this in the website folder?

@DanielEmmanuel1 DanielEmmanuel1 self-requested a review May 3, 2025 01:57
DanielEmmanuel1
DanielEmmanuel1 requested changes May 3, 2025
View reviewed changes
Copy link
Collaborator

@DanielEmmanuel1 DanielEmmanuel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please go through the figma file once more and make theses changes
The grid and list isn't functional either.
Please make these changes

dapp/src/app/view-listed-asset/component/ListingInfo.tsx
Copy link
Collaborator

@DanielEmmanuel1 DanielEmmanuel1 May 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nothing like the actual design

dapp/src/app/view-listed-asset/component/LoanTable.tsx
Copy link
Collaborator

@DanielEmmanuel1 DanielEmmanuel1 May 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just looks wrong! nothing like the actual design
padding and margins are way off, bg colors and not matching
Fix this!!!

Copy link
Collaborator

@DanielEmmanuel1 DanielEmmanuel1 May 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about pagination?
I don't see that here at all

dapp/src/app/view-listed-asset/page.tsx
Copy link
Collaborator

@DanielEmmanuel1 DanielEmmanuel1 May 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go back button doesn't match what's in figma

website/src/app/view-listed-asset/component/ListingInfo.tsx
Copy link
Collaborator

@DanielEmmanuel1 DanielEmmanuel1 May 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text colors or text size don't match at all

website/src/app/view-listed-asset/component/FilterBar.tsx
Copy link
Collaborator

@DanielEmmanuel1 DanielEmmanuel1 May 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filter mechanism don't actually work and is just hardcoded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DanielEmmanuel1 DanielEmmanuel1 DanielEmmanuel1 requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build the View Listed Asset Interface

2 participants

@devJaja @DanielEmmanuel1